-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dotnet8 #1031
base: develop
Are you sure you want to change the base?
Dotnet8 #1031
Conversation
src/SoapCore/SoapCore.csproj
Outdated
<TargetFrameworks>netstandard2.0;netstandard2.1;netcoreapp3.1;net5.0;net6.0</TargetFrameworks> | ||
<TargetFrameworks>netstandard2.0;netstandard2.1;net7.0;net8.0</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the benefit in removing net core 3.1, net 5/6. At the same time only marginal benefit of having net 7. I would propose we first merge in #1052
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had the time to work on this one for a while. Will probably resume work in a couple of weeks.
net core 3.1 and net 5 are already covered by targeting netstandard.
Agree about net 7 though. It's already out of support and I don't see a reason to keep it around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the dependency graph if you want to reduce target framework I would stick with net core 3 as otherwise u would be forcing all projects < net 8 to take on a deprecated dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this works for you? we had some difficulties making this work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will this be merged with the already merged pr's with a new nuget package?
Had a question, any tentative timeline for the release? |
I've merged the origin/develop into @andersjonsson dotnet8 branch, and did some other changes. |
@andersjonsson Net 6 goes out of support in Nov, could we expect a release in oct for this? |
Sorry for the lack of activity on this branch. Life... |
I've merged origin/develop into andersjonsson/dotnet8 |
also updated nuget packages